CB-11699 Read files as Data URLs properly #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading file as Data URL, CHUNK_SIZE must be divisible by 3, otherwise the resultant string made by concatenating chunks will not be a valid Base64 encoded Data URL. Also Windows do not support reading sliced files as data URLs, so we set chunk size equal to file size
|
Please do review this as the function in the current release does not work for files over a very small size. |
|
can we expect a fix for this soon? |
|
@Samaludheen, the fix has been released recently. Check out cordova-plugin-file@4.3.0 |
|
@vladimir-kotikov Thank you a lot, your PR fixed exactly an issue I was facing today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android, iOS, Windows
What does this PR do?
This PR fixes reading files as data URLs by modifying chunk size, so concatenated chunks would be a valid Data URL
What testing has been done on this change?
Ran plugin tests on all affected platforms
Checklist
When reading file as Data URL, CHUNK_SIZE must be divisible by 3, otherwise the resultant string, made by concatenating chunks, will not be a valid Base64 encoded Data URL. Also Windows do not support reading sliced files as data URLs, so we need to set chunk size equal to file size.
Relevant JIRA issues: CB-11699, CB-11199