fix(browser): Error on browser platform #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try to use this while running `cordova run browser`, this line will always fail because URI starts with 'http://localhost:8000/'. Changing it to 3 fixes this issue, but I'm unclear if there are unintended consequences.
janpio
changed the title
Apache Cordova: Plugin Pull Requests
automation
moved this from ⛔ Blocked: Tests failing
to ☠️ Closed/Abandoned
Jul 4, 2019
|
Rerun tests |
Apache Cordova: Plugin Pull Requests
automation
moved this from ☠️ Closed/Abandoned
to 🐣 New PR / Untriaged
Jul 4, 2019
Apache Cordova: Plugin Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ☠️ Closed/Abandoned
Jul 4, 2019
|
CI: Once more please. |
Apache Cordova: Plugin Pull Requests
automation
moved this from ☠️ Closed/Abandoned
to 🐣 New PR / Untriaged
Jul 4, 2019
janpio
moved this from 🐣 New PR / Untriaged
to ⏳ Ready for Review
in Apache Cordova: Plugin Pull Requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to use this while running
cordova run browser, this line will always fail because URI starts with 'http://localhost:8000/'. Changing it to 3 fixes this issue, but I'm unclear if there are unintended consequences. I'm not familiar enough with the code base to fully test etc, but hopefully someone with more knowledge can easily tell.