Update Metadata.js

[DanielFreiburger]

File was not updated correct after changing "modificationTime" to "lastModifiedDate"

[shazron]

Not sure this is correct. The spec says it should be "modificationTime": http://dev.w3.org/2009/dap/file-system/pub/FileSystem/

The js function that uses Metadata:

cordova-plugin-file/www/Entry.js

Lines 65 to 75 in 21e1196

	Entry.prototype.getMetadata = function(successCallback, errorCallback) {
	argscheck.checkArgs('FF', 'Entry.getMetadata', arguments);
	var success = successCallback && function(entryMetadata) {
	var metadata = new Metadata(entryMetadata);
	successCallback(metadata);
	};
	var fail = errorCallback && function(code) {
	errorCallback(new FileError(code));
	};
	exec(success, fail, "File", "getMetadata", [this.filesystem.__format__(this.fullPath)]);
	};

On iOS, it is modificationTime:

cordova-plugin-file/src/ios/CDVLocalFilesystem.m

Line 278 in 21e1196

result = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsDictionary:@{@"modificationTime": @([modDate timeIntervalSince1970] * 1000), @"size": @(size)}];

But, on Android it's lastModifiedDate:

cordova-plugin-file/src/android/LocalFilesystem.java

Line 297 in 757e692

metadata.put("lastModifiedDate", file.lastModified());

So I think this is a bug in Android.

[shazron]

Also, Android has all these extra properties that are not part of the spec:

cordova-plugin-file/src/android/LocalFilesystem.java

Lines 294 to 296 in 757e692

	metadata.put("type", FileHelper.getMimeType(file.getAbsolutePath(), cordova));
	metadata.put("name", file.getName());
	metadata.put("fullPath", inputURL.fullPath);

[alessandronunes]

What about the "com.apple.MobileBackup"? I'm trying to set it but neither the success or the fail callback function is being called.

[shazron]

@alessandronunes this was a bug in the File plugin. It should be fixed in the dev branch, or wait an hour or so when the new plugin version gets published.

[shazron]

Woops, it just happened - plugins are released! http://cordova.apache.org/news/2014/04/23/plugins.release.html

[alessandronunes]

Thanks Shaz! Do you know when, usually, Phonegap gets updated after this?

[shazron]

For Plugins, we aim for a weekly release, however prior to this, our last one was over 5 weeks ago I think. For the core platforms, we used to aim for a monthly release, but now it is indeterminate.

[alessandronunes]

Thanks again. Good job!

[clelland]

It looks like the mobilespec test for this just checked that metadata.modificationTime instanceof Date was true. Unfortunately,

new Date(undefined) instanceof Date === true

So it never failed. :(

Definitely a bug in Android; I'll fix that for the next release.

[DanielFreiburger]

In File.js always "lastModifiedDate" is used,
in Metadata.js always "modificationTime" is used
but there is no correlation between these two.
So one of the two must be wrong.
After creating a correlation between the two by changing Metadata.js line 29 from:
this.modificationTime = new Date(metadata.modificationTime);
to
this.modificationTime = new Date(metadata.lastModifiedDate);
everything is fine.

[shazron]

Hmm File.js represents the File interface in the File API spec: http://www.w3.org/TR/FileAPI/#file and it does specify lastModifiedDate, which is correct.

FileEntry.file is correct, it should return a File object, so that's fine -- but it has a bug in it in how it constructs the File object. Since it is calling the getMetadata function, the call to get the date should be f.modificationTime instead of f.lastModifiedDate (since the returned object to the successcallback is a Metadata object):

cordova-plugin-file/www/FileEntry.js

Line 71 in 767e2c5

var file = new File(f.name, localURL, f.type, f.lastModifiedDate, f.size);

[clelland]

I've created CB-6922 for this -- it was certainly a problem in Android.

The trouble, as Shaz identified, is that both the File API and the FileEntry API have a method to get metadata for a file, and they use inconsistent names for the timestamp.

I've committed a different fix, which just makes use of getFileMetadata for both functions (on all platforms) and changes the key names in JavaScript before instantiating the Metadata object. This should ensure consistent behaviour across all platforms.

[clelland]

This fix has been committed, and the tests are ensuring that the correct keys appear in the callbacks. You can close this pull request, I think.