Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Require android 9 #439

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Nov 25, 2020

Platforms affected

Android

Motivation and Context

Depends on #438
Closes #424

Bumps engines to require >= cordova-android@9.0.0. This is because #417 requires the user to have the android build tools version 29 installed, which is tested and supported as of cordova-android@9.0.0.

Description

Bump engines for cordova-android to >= 9.0.0

Testing

N/A

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek requested a review from erisu November 25, 2020 11:54
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@breautek breautek merged commit 6cfad27 into apache:master Nov 25, 2020
@breautek breautek deleted the require-android-9 branch November 25, 2020 12:55
Luro91 added a commit to platogo/cordova-plugin-file that referenced this pull request Jan 25, 2022
pmcquay pushed a commit to BetterImpact/cordova-plugin-file that referenced this pull request Sep 2, 2022
* chore: bump version to 7.0.0-dev

* chore: bump android engine requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix for #417 breaks the build for any apps targeting sdk 28 and lower.
2 participants