Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Request permission Android <= 10 on API 33 #587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexisGandar
Copy link

Platforms affected

Motivation and Context

On Android 10 and below, on cordova-plugin-file V8 and cordova-android V12 the permission request was not displayed to the user witch lead to an error when trying to write a file in the externalRootDirectory + '/Download' folder.

Permission not requested on Android 10 when targeting API 33 (#586)

Description

This fix always ask for permission if needed on GetFile action. This allow to fix the bug.

Testing

I test on Android 10/11/12/13 that writing a file to externalRootDirectory + '/Download' works.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant