fix!: Bump engine requirements android >= 10, ios >= 6 #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android / iOS
Motivation and Context
There were concerns raised during 5.0.0 release: https://lists.apache.org/thread/dzmm273b76pngtor6386s71yzf6lzxck
To address these concerns, this caveat is noted in the release blog (see apache/cordova-docs#1335). While this is technically a breaking change it can be thought of a patch onto 5.0.1 and be included in our next patch or feature release.
Description
Bump engine versions in both plugin.xml and package.json
cordova-android >= 10 for min SDK 22 (cordova-android 9 also had minSDK 22 but dependent on jfrog)
cordova-ios >= 6 for iOS 11 minimum deployment
iOS 11 has good support for ES6 (however with some buggy behaviour)
SDK 22 ships with Chrome 33 which has, but
let
was only introduced Chrome 49 (41 with strict mode). So it's possible that SDK 22 won't be sufficient, depending on the end-users webview version but this is upgradeable and the latest version available for these devices is Chrome ~70.Cordova-android@12 has a min SDK of 24 which AOSP simulators ships with Chrome 53. In all likeliness this is what most people will see.
Additionally I updated the README to mention these new requirements.
Testing
ran npm test
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)