Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13294 Remove cordova-plugin-compat #96

Closed
wants to merge 1 commit into from

Conversation

kelvindart
Copy link

Platforms affected

cordova-android@6.3.0

What does this PR do?

Removes the dependency on cordova-plugin-compat, and includes checks for min platform version.

What testing has been done on this change?

Testing 1:

  • Add local plugin to project containing cordova-android@6.3.0
  • Verify plugin installs, and app runs.

Testing 2:

  • Add local plugin to project containing cordova-android@6.2.3
  • Verify plugin does not install.
  • Console log as follows:
Plugin doesn't support this project's cordova-android version. cordova-android: 6.2.3, failed version requirement: >=6.3.0
Skipping 'cordova-plugin-geolocation' for android

This is desirable - this change stops the plugin being installed on <cordova-android@6.3.0

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@asfgit asfgit closed this in 642a2f3 Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants