Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving issue #417 generated a new issue for inappbrowser when using usewkwebview=yes #424

Closed
mosabab opened this issue Feb 11, 2019 · 5 comments

Comments

@mosabab
Copy link
Contributor

mosabab commented Feb 11, 2019

@janpio @dpa99c @agrieve @stevengill @shazron @purplecabbage @timbru31 @sgrebnov
(After the old issue #417 solved , there is a new issue appear in inappbrowser load errors if you open any websites. and warning messages appear from header).
When @janpio @dpa99c edited the code to resolve #417 issue, there a new issue generated.

Please check inappbrowser plugin master version and try to open any website inside inappbrowser using usewkwebview=yes, and you will see that you can't see the websites.

You can try to open: https://www.trivago.com/ in inappbrowser as an example.

Before solving issue #417 , this new issue not appear, it is just appear after issue #417 solved.

Please check

Thanks.
Regards.

@mosabab
Copy link
Contributor Author

mosabab commented Feb 11, 2019

@janpio @dpa99c please check the previous updated code, now: you can't open any websites, HEADER BROWSER HAVE AN ERROR

@mosabab mosabab changed the title Inappbrowser with usewkwebview=yes cannot access external domains with errors appear Inappbrowser with usewkwebview=yes cannot open websites after issue #417 solved Feb 11, 2019
@mosabab mosabab changed the title Inappbrowser with usewkwebview=yes cannot open websites after issue #417 solved Solving issue #417 generated a new issue for inappbrowser when using usewkwebview=yes Feb 11, 2019
@dpa99c
Copy link
Contributor

dpa99c commented Feb 11, 2019

OK, I see the problem here. My fix for #417 is screwing up sites using iframes (such as Trivago) because it's also redirecting those cross-frame requests back to the main IAB frame.
What it needs to do is only redirect the request back to the main frame if the target attribute is "_blank".
That should handle both cases.

dpa99c added a commit to dpa99c/cordova-plugin-themeablebrowser that referenced this issue Feb 11, 2019
@mosabab
Copy link
Contributor Author

mosabab commented Feb 11, 2019

Hello @dpa99c
Thanks for reply,
When you will fix the issue for the master version ?

Regards

dpa99c added a commit to dpa99c/cordova-plugin-themeablebrowser that referenced this issue Feb 11, 2019
@dpa99c
Copy link
Contributor

dpa99c commented Feb 11, 2019

@mosababubakr I have created PR #425 which should resolve this issue and also preserve the fix for #417.

Please could you test the changes on my branch and confirm they resolve all your issues before this PR is merged to master.

To install the plugin direct from my branch, you can use:

cordova plugin add https://github.com/dpa99c/cordova-plugin-themeablebrowser#GH-242-fix-ios-wkwebview-iframes

@janpio would be good to have some wider testing of this before it gets merged to confirm no other regression bugs have been introduced.

@mosabab
Copy link
Contributor Author

mosabab commented Feb 11, 2019

Hello @dpa99c
Thanks for help,
I try to use the plugin you mentioned and every things work fine now.

Thanks

Just now we wait for the master version to merge and fix these issue.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants