Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallowOverscroll option #10

Closed
wants to merge 5 commits into from
Closed

disallowOverscroll option #10

wants to merge 5 commits into from

Conversation

apla
Copy link
Contributor

@apla apla commented Nov 10, 2013

similar to the main cordova webview

@agrieve
Copy link
Contributor

agrieve commented Dec 6, 2013

Sorry for not seeing this sooner.

Created JIRA issue for this:
https://issues.apache.org/jira/browse/CB-5594

Before we can merge your code, I need to confirm that you have signed the Apache Contributor License Agreement?
http://www.apache.org/licenses/#clas

@apla
Copy link
Contributor Author

apla commented Dec 6, 2013

yes, i have signed it

On Dec 6, 2013, at 7:06 PM, agrieve notifications@github.com wrote:

Sorry for not seeing this sooner.

Created JIRA issue for this:
https://issues.apache.org/jira/browse/CB-5594

Before we can merge your code, I need to confirm that you have signed the Apache Contributor License Agreement?
http://www.apache.org/licenses/#clas

—
Reply to this email directly or view it on GitHub.

@agrieve
Copy link
Contributor

agrieve commented Dec 13, 2013

Great. I've merged this in. You can find the commits linked to the JIRA issue:
https://issues.apache.org/jira/browse/CB-5594

Thanks for the patch! Please close the pull request.

@agrieve
Copy link
Contributor

agrieve commented Feb 10, 2014

@apla Please close this pull request

@apla apla closed this Feb 10, 2014
jcesarmobile pushed a commit to jcesarmobile/cordova-plugin-inappbrowser that referenced this pull request Apr 27, 2020
@tlancina
Merge pull request apache#10 from ionic-team/ionic-native-reexport
358a991 
ionic native reexport
growthengineering pushed a commit to growthengineering/cordova-plugin-inappbrowser that referenced this pull request Jul 24, 2020
Merged in en-fix-video-full-screen-inside-inappbrowser-android-WKWebV…
c48b7e7 
…iew (pull request apache#10)

Fix video full screen inside inappbrowser Android with WKWebView

Approved-by: João Lourenço <joao.lourenco@growthengineering.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apla @agrieve