CB-8467 provide hide method to hide browser window #101

herrevilkitten · 2015-04-04T02:21:51Z

Added support for hiding the web view container. This maintains the browser
session without closing it. The browser window can be repeatedly hidden and
shown.

** This has only been tested on android and ios **

amazon/android:
An additional hide action was added to InAppBrowser#execute. It is
identical to show, except that it calls dialog.hide() instead.

blackberry10:
no changes

firefoxos:
Added a hide method that is identical to show, indicating it is not
supported.

ios:
Added a hide method that is identical to show, except that it uses
dismissViewControllerAnimated. It checks the value of
_previousStatusBarStyle. If it is -1, the method returns with no
action performed. If it is not, it is set to -1.

ubuntu:
Added a hide method that sets CordovaWrapper.global.inappbrowser.visible to
false.

windows:
Added a hide method that sets browserWrap.style.display to none.

wp:
Added a hide method that is identical to show, except that it sets
browser.Visibility to Visibility.Collapsed and sets AppBar.IsVisible to
false.

schoettler · 2015-08-06T13:34:25Z

+1

zalun · 2015-09-09T13:07:21Z

FFOS +1

sgrebnov · 2016-02-08T19:20:13Z

lgtm

sfrank87 · 2016-10-18T07:55:25Z

Hi,
I am interested in this functionality, too. It’s a pity, it never found its way to the upstream repository. :/
Could you please solve the merge conflicts? That would be great. :D
Thanks a lot!

Frank

PaulBaugher

Can we get this in?

herrevilkitten · 2016-10-18T14:23:31Z

Sure I can fix the conflicts. It's ... been a while

Added support for hiding the web view container. This maintains the browser session without closing it. The browser window can be repeatedly hidden and shown. ** This has only been tested on android and ios ** amazon/android: An additional `hide` action was added to `InAppBrowser#execute`. It is identical to `show`, except that it calls `dialog.hide()` instead. blackberry10: no changes firefoxos: Added a `hide` method that is identical to `show`, indicating it is not supported. ios: Added a `hide` method that is identical to `show`, except that it uses `dismissViewControllerAnimated`. It checks the value of `_previousStatusBarStyle`. If it is `-1`, the method returns with no action performed. If it is not, it is set to `-1.` ubuntu: Added a `hide` method that sets `CordovaWrapper.global.inappbrowser.visible` to `false`. windows: Added a `hide` method that sets `browserWrap.style.display` to `none`. wp: Added a `hide` method that is identical to `show`, except that it sets `browser.Visibility` to `Visibility.Collapsed` and sets `AppBar.IsVisible` to `false`.

herrevilkitten · 2016-10-18T14:43:19Z

@sfrank87 @digitalskyline conflicts de-conflicts, checks passed

cordova-qa · 2016-10-18T19:04:37Z

Cordova CI Build has one or more failures.

Commit - Link
Dashboard - Link

Builder Name	Console Output	Test Report	Device Logs
Windows 8.1 Store	Link	Link	Link
Windows 10 Store	Link	Link	Link
Windows 8.1 Phone	Link	Link	Link
iOS	Link	Link	Link
Android	Link	Link	Link

jcesarmobile · 2016-10-18T22:15:01Z

let there be tests

cordova-qa · 2016-10-18T22:30:33Z

Cordova CI Build has one or more failures.

Commit - Link
Dashboard - Link

Builder Name	Console Output	Test Report	Device Logs
Windows 8.1 Store	Link	Link	Link
Windows 10 Store	Link	Link	Link
Windows 8.1 Phone	Link	Link	Link
iOS	Link	Link	Link
Android	Link	Link	Link

sfrank87 · 2016-10-19T08:26:56Z

Hi.
Thank you very much for your effort. :)

I found an misstake in CDVInAppBrowser.m. The hide method was implemented twice, in line 246 and in line 270. ^^"

However, I wonder what's wrong with the android build. After all, the hide implementation is an exact copy of show, except for two words. (i diffed both sections, seems no misstakes). And the Jenkins log seems a bit strange, too. For me, it’s a bit conspicuous that it says “no workspace”. O.o

regards
Frank

sfrank87 · 2016-10-19T09:06:56Z

Btw, I have written a little test case for the hide method, that can be found here.

@herrevilkitten just copy&paste the tests.js into the tests/ folder. This adds a litte automatic test, checking for the existence of the JS hide method and a manual test that opens the IAB, than hides it after 2 seconds.

regards
Frank

jcesarmobile · 2016-10-19T09:20:37Z

@sfrank87 can you send a PR to @herrevilkitten repo against CB-8467_provide_hide_method_to_hide_browser_window branch removing the duplicate method and adding the test?

sfrank87 · 2016-10-19T09:41:35Z

@jcesarmobile

done.

regards
Frank

PaulBaugher · 2016-10-19T11:30:03Z

I added this to my project much appreciated!

…de_browser_window removed duplicate hide method in ios source and add jasmine test cases

herrevilkitten · 2016-10-19T11:36:41Z

Thanks you @sfrank87 for the help with this :)
The duplicate methods are probably from some wacky merge conflict resolution I had going on.

jcesarmobile · 2016-10-19T12:35:25Z

let there be tests

cordova-qa · 2016-10-19T18:00:41Z

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name	Console Output	Test Report	Device Logs
Windows 8.1 Store	Link	Link	Link
Windows 10 Store	Link	Link	Link
Windows 8.1 Phone	Link	Link	Link
iOS	Link	Link	Link
Android	Link	Link	Link

jcesarmobile · 2016-10-19T21:21:53Z

merged, thank you everyone and sorry that it took so long

bgallz · 2017-06-27T21:56:41Z

Thank you for providing this update!

I have one question however. I am using Ionic v2.1.4 with iOS v4.0.1 (not sure that's relevant in this case) and I am seeing that the view controller used in the hide method here does not have any effect.

This line:
[self.viewController dismissViewControllerAnimated:YES completion:nil];

Does not appear to do anything. However, when I make the dismiss call like so:
[self.inAppBrowserViewController dismissViewControllerAnimated:YES completion:nil];

The InAppBrowser is hidden as expected. Can anyone else confirm this?

Thanks again!

jcesarmobile · 2017-06-27T22:07:49Z

@bgallz there is a bug (already reported) about hide not working because of other changes.

bnova-stefan · 2017-07-19T15:02:24Z

Hi @jcesarmobile
Could you tell me more about the bug? I have to hide the browser to scan something with the camera and fill in the scanned value in a form field.
Is there any workaround to hide the browser window?

Thank you very much
Stefan

herrevilkitten · 2017-07-19T15:25:51Z

@bnova-stefan It appears to be https://issues.apache.org/jira/browse/CB-12586

PaulBaugher approved these changes Oct 18, 2016

View reviewed changes

herrevilkitten force-pushed the CB-8467_provide_hide_method_to_hide_browser_window branch 2 times, most recently from 21b131a to c70882f Compare October 18, 2016 14:39

herrevilkitten force-pushed the CB-8467_provide_hide_method_to_hide_browser_window branch from c70882f to df8bcaf Compare October 18, 2016 14:41

removed duplicate hide method in ios source and add jasmine test cases

20c21f3

sfrank87 mentioned this pull request Oct 19, 2016

removed duplicate hide method in ios source and add jasmine test cases herrevilkitten/cordova-plugin-inappbrowser#1

Merged

Merge pull request #1 from sfrank87/CB-8467_provide_hide_method_to_hi…

98ed7f7

…de_browser_window removed duplicate hide method in ios source and add jasmine test cases

asfgit closed this in e853399 Oct 19, 2016

saschal-j5int pushed a commit to saschal-j5int/cordova-plugin-inappbrowser that referenced this pull request Oct 23, 2023

Github close apache#101, close apache#25, close apache#54

c79ee36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CB-8467 provide hide method to hide browser window #101

CB-8467 provide hide method to hide browser window #101

herrevilkitten commented Apr 4, 2015

schoettler commented Aug 6, 2015

zalun commented Sep 9, 2015

sgrebnov commented Feb 8, 2016

sfrank87 commented Oct 18, 2016

PaulBaugher left a comment

herrevilkitten commented Oct 18, 2016

herrevilkitten commented Oct 18, 2016

cordova-qa commented Oct 18, 2016

jcesarmobile commented Oct 18, 2016

cordova-qa commented Oct 18, 2016

sfrank87 commented Oct 19, 2016

sfrank87 commented Oct 19, 2016

jcesarmobile commented Oct 19, 2016

sfrank87 commented Oct 19, 2016

PaulBaugher commented Oct 19, 2016

herrevilkitten commented Oct 19, 2016

jcesarmobile commented Oct 19, 2016

cordova-qa commented Oct 19, 2016

jcesarmobile commented Oct 19, 2016

bgallz commented Jun 27, 2017

jcesarmobile commented Jun 27, 2017

bnova-stefan commented Jul 19, 2017

herrevilkitten commented Jul 19, 2017

CB-8467 provide hide method to hide browser window #101

CB-8467 provide hide method to hide browser window #101

Conversation

herrevilkitten commented Apr 4, 2015

schoettler commented Aug 6, 2015

zalun commented Sep 9, 2015

sgrebnov commented Feb 8, 2016

sfrank87 commented Oct 18, 2016

PaulBaugher left a comment

Choose a reason for hiding this comment

herrevilkitten commented Oct 18, 2016

herrevilkitten commented Oct 18, 2016

cordova-qa commented Oct 18, 2016

jcesarmobile commented Oct 18, 2016

cordova-qa commented Oct 18, 2016

sfrank87 commented Oct 19, 2016

sfrank87 commented Oct 19, 2016

jcesarmobile commented Oct 19, 2016

sfrank87 commented Oct 19, 2016

PaulBaugher commented Oct 19, 2016

herrevilkitten commented Oct 19, 2016

jcesarmobile commented Oct 19, 2016

cordova-qa commented Oct 19, 2016

jcesarmobile commented Oct 19, 2016

bgallz commented Jun 27, 2017

jcesarmobile commented Jun 27, 2017

bnova-stefan commented Jul 19, 2017

herrevilkitten commented Jul 19, 2017