Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to next major release 6.0.0 #1033

Merged
merged 4 commits into from Nov 10, 2023
Merged

chore: bump to next major release 6.0.0 #1033

merged 4 commits into from Nov 10, 2023

Conversation

NiklasMerz
Copy link
Member

Platforms affected

Motivation and Context

Prepare for next release

See list https://lists.apache.org/thread/p2ycdfv4tf0vnt1dbkv1160o5xz5knns

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In package.json this has to be updated to 7.0.0 or plugin will fail to update

@NiklasMerz
Copy link
Member Author

In package.json this has to be updated to 7.0.0 or plugin will fail to update

I updated cli & ios to last major release. Is that correct? Android is not needed, yet I guess from the commits in master right?

@jcesarmobile
Copy link
Member

I don't think we need them to be latest, cordova-ios 6 supports the same iOS versions as cordova-ios 7. And for the CLI I'm not aware of any reason to bump it, maybe because of nodejs support?
A cordova-android entry is needed, in geolocation plugin it was set to >=10.0.0 recently.
https://github.com/apache/cordova-plugin-geolocation/blob/master/package.json#L34-L37

@NiklasMerz
Copy link
Member Author

That sounds good to me. I set the same requirements and kept cli from the previous version. Thanks for the help @jcesarmobile. I never really dug into these requirements before.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NiklasMerz NiklasMerz merged commit bc17634 into master Nov 10, 2023
18 of 21 checks passed
@NiklasMerz NiklasMerz deleted the major-bump branch November 10, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants