CB-12468 added ability to set|get default options; #213
Conversation
IvanProdaiko94
changed the title
|
Any estimates to merge it in master? |
|
Let there be tests |
|
Any changes to be rebased to master? What shell I do to improve pull in order to get this done? |
|
Have the same issue on IOS. Probably fixing ios is needed to, but seems that it's good workaround compatible with all systems. Why not merge? |
|
We don't merge if it doesn't merge cleanly, that's why it didn't get merged most likely. |
|
It was ok year ago :) |
|
Give this PR one more try, please) |
|
Some CI check seems to be broken :( |
|
@IvanProdaiko94 could you please rebase onto |
janpio
moved this from ⛔ Blocked: Tests failing
to ⏳ Ready for Review
in Apache Cordova: Plugin Pull Requests
|
@janpio ok |
IvanProdaiko94
force-pushed
the
master
branch
from
9d3889e
to
8e47187
Compare
styling fixes final eslint fix fixed types
IvanProdaiko94
force-pushed
the
master
branch
from
8e47187
to
53ee44e
Compare
janpio
moved this from ⏳ Ready for Review
to ⛔ Blocked: Tests failing
in Apache Cordova: Plugin Pull Requests
|
One last rebase on |
|
Closing and re-opening to trigger a new CI/test run with new PR merge. |
janpio
moved this from 🐣 New PR / Untriaged
to ⏳ Ready for Review
in Apache Cordova: Plugin Pull Requests
While using plugin I must set popup features only when calling window.open method. But a lot of libraries (firebase, openFB) use window.open inside their own code where I can't directly menage the features of window to be opened, and on IOS, where we do not a have a 'back' button we could have a problem. For example window, opened with 'toolbar=no' will make app to stack with no ability to close the window. Another thing to be mentioned is when on IOS you use
So, my proposal is to provide an ability to setDefaultOptions method that will help to prevent external libraries to manage the options of of window to be opened directly. If pass a '(required)' in option like that 'location=no(required)' than any option provided in window.open method will not affect on the default settings.
I tested it in my projects (IOS|Android), and everything works fine;