Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Appcache for the android webview #239

Closed
wants to merge 2 commits into from
Closed

Enabling Appcache for the android webview #239

wants to merge 2 commits into from

Conversation

walisc
Copy link

@walisc walisc commented Sep 5, 2017

Enabling App Caching for the android webview instance. Disabled by default.

@walisc walisc closed this Sep 5, 2017
@janpio
Copy link
Member

janpio commented Sep 5, 2017

What exactly is AppCaching in this context?

@andreszs
Copy link

andreszs commented Sep 17, 2017

@janpio @walisc
Is this the same cache that caches all images as they are requested by the app? (not the images from an eventual webview control, I mean every single image downloaded and shown dynamically)

The current app cache has no limit and grows until the internal device memory has been depleted, which renders any Android 4.x/5.x device unusable. Putting a limit to such cache would be a great idea.

@walisc
Copy link
Author

walisc commented Sep 21, 2017

Hi @janpio and @janpio Apologies for this pull request. Was intended for my company's branch. We need to enable AppCaching for the inappbrowser as we serve our app remotely (for security reasons) yet we still want it be available offline . @janpio re:- limit, yes I agree with you. the second commit removed this limit.

@janpio
Copy link
Member

janpio commented Sep 21, 2017

No need to apologize, I was just curious what this does and if it would make sense to actually have this in the plugin for all users, maybe behind a configuration or option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants