Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InAppBrowser.java #240

Closed
wants to merge 1 commit into from
Closed

Update InAppBrowser.java #240

wants to merge 1 commit into from

Conversation

ahmedfawky
Copy link

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@infil00p
Copy link
Member

Rejecting this PR since we're not supporting a non-generic scheme in InAppBrowser. WhatsApp is just like any other app and doesn't get special status like geo: , mailto: or tel:

@asfgit asfgit closed this in e9878dd Sep 27, 2017
@coolvasanth
Copy link

@infil00p can you please tell me from cordova side how to open geo or mailto to tel kind of URL's.

window.open = cordova.InAppBrowser.open;
window.open('market://:', 'blank')

When I try above code it just opens in browser with http://market or tel, but I want to open Playstore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants