Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-13662: remove deprecated platforms #253

Merged
merged 1 commit into from
Dec 14, 2017
Merged

CB-13662: remove deprecated platforms #253

merged 1 commit into from
Dec 14, 2017

Conversation

surajpindoria
Copy link
Member

Platforms affected

Deprecated platforms

What does this PR do?

Removes deprecated platforms

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

macdonst
macdonst requested changes Dec 12, 2017
View reviewed changes
Copy link
Member

@macdonst macdonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take out windows8

plugin.xml Outdated

<source-file src="src/wp/InAppBrowser.cs" />
</platform>

<!-- windows8 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surajpindoria I think you want to get rid of this platform too.

stevengill
stevengill approved these changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevengill stevengill merged commit 309cdef into apache:master Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macdonst macdonst macdonst requested changes

@stevengill stevengill stevengill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@surajpindoria @stevengill @macdonst