Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12922 (ios): fix In-app browser does not cede control #272

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

jcesarmobile
Copy link
Member

Platforms affected

iOS

What does this PR do?

fix InAppBrowser not giving control back to the app after showing the keyboard.

What testing has been done on this change?

Tested on real iPhone device.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@morellan
Copy link

This solved my problem, I'm using @jcesarmobile now. Any news on when this would be merged?

@jcesarmobile jcesarmobile merged commit 9cc7f69 into apache:master Jul 11, 2018
@jcesarmobile jcesarmobile deleted the CB-12922 branch July 11, 2018 22:30
cjy37 added a commit to cjy37/cordova-plugin-inappbrowser-x5webview that referenced this pull request Jul 27, 2018
This reverts commit 9cc7f69, reversing
changes made to 26cf6e4.
@alan-grixti
Copy link

Hi, I've integrated your fixes into my local version of the plugin however I am not managing to get it working. Was the issue by any chance that of when opening a keyboard in the inappbrowser and closing the browser instance, the app would just hang? Mine is giving the error <_UIKBCompatInputView: 0x7fe250d1cd30; frame = (0 0; 0 0); layer = <CALayer: 0x60400022a6e0>> returned 0 width, assuming UIViewNoIntrinsicMetric 2018-09-11 10:52:49.439194+0200 too. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants