Some bugs corrected #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java.lang.RuntimeException: java.lang.Throwable: Warning: A WebView method was called on thread 'WebViewCoreThread'. All WebView methods must be called on the UI thread. Future versions of WebView may not support use on other threads. FIXED
Remove buggy code
Some chars like 'º' don't escape well with function window.escape, is better use encodeURIComponent to prevent errors on decode.
|
Thanks for the fixes! Sorry to not have seen them sooner. The Android one has already been fixed in the meantime, but I've reported the iOS one as: And merged it in: Please close the pull request. |
|
@javray Please close this PR |
|
Sorry, I forgot to close it. |
JohnCashmore
pushed a commit
to shapingcloud/cordova-plugin-inappbrowser
that referenced
this pull request
Feb 20, 2015
growthengineering
pushed a commit
to growthengineering/cordova-plugin-inappbrowser
that referenced
this pull request
Jul 10, 2020
[ TKA-320 ] Fix topnotch ios bar Approved-by: Eric Nyangezi <eric.nyangezi@growthengineering.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct some bugs in Android and iOS versions.