-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update InAppBrowser.java to allow custom URI schemes and intents #551
base: master
Are you sure you want to change the base?
Conversation
in line with allowing custom URI schemes and this issue I've changed the if statement that enforces http for no apparent reason: apache#548
allow custom URI schemes and intents |
I could really use this right now. I have a need to redirect to a custom url scheme which is working great in iOS, but is dead in the water in Android. |
Looks like there was already a long discussion about custom schemes for iOS in this PR #274 Those two PR should be reviewed together. |
In addition to #274, I discovered 2 more PRs that looks related:
We would like to keep the behavior on Android, iOS, and other platforms as consistent as possible. I don't know if we should discuss this in an existing issue, new issue, or somewhere else? |
Indeed. It looks like #263 already introduces But the inconsistencies may still exists, like said in the other PRs. |
@AhrenFullStop Did you try #263 to solve your problem? We would like to understand if this PR is still necessary for certain use cases. |
in line with allowing custom URI schemes and this issue I've changed the if statement that enforces http for no apparent reason: #548
Platforms affected
IOS and Android, allows custom URI Schemes
Motivation and Context
fixes issue here: #548
Allows the user to use window.open() to open custom URI's such as intents (tel:// or anotherapp://) easily.
Description
All I did was remove an if statement that checks for the URI starting with Http, Https or File. so that the uri can be in any format.
Testing
Tested locally, working.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)