(ios): rename CDVWKProcessPoolFactory

[NiklasMerz]

Platforms affected

iOS

Motivation and Context

CDVWKProcessPoolFactory was integrated from the WKWebView plugin with
the new name: CDVWebViewProcessPoolFactory

Description

This fixes the import of the processpool factory for cordova-ios versions 6 or greater. The process pool is now part of cordova-ios and needs to be available public see: apache/cordova-ios#1031

Closes #751

Testing

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[timbru31]

LGTM, but obviously only if we merge in apache/cordova-ios#1031 :)

[timbru31]

With Darryl's suggestion the milestone could be moved to a minor release I guess?

[NiklasMerz]

Yes the change is not breaking anymore. Looks like the next release will be major anyways and we don't have a minor milestone.

[jcesarmobile]

since 4.1.0 introduced breaking changes maybe we should do a minor release first that fixed that problem and then we can continue with the breaking changes.
But that would mean we need to rever the merged breaking changes to be able to do a minor release

or we can continue with the major release as not supporting Xcode 10 is not a big issue since its builds are not accepted in the App Store

[NiklasMerz]

Yeah I was just thinking about when and how to release next. Maybe we should do a discuss thread on the list.

Personally I think I would go for a major release now. I would agree that supporting Xcode 10 should not be that important since Xcode 11 is required for the app store and the current release is even 12. We should reduce our workload and move forward with the limited time we have.

@jcesarmobile Do you know issues or users about Xcode 10?

[jcesarmobile]

@jcesarmobile Do you know issues or users about Xcode 10?

Don't understand the question, the issue on Xcode 10 is linked on my previous comment #831

The easy fix for users is to use Xcode 11 or newer to compile, if we wanted to support it a #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 130000 macro should be used, but probably not worth it

[NiklasMerz]

I was just asking if you know about people having issues with this version. I personally always prioritize work if users are complaining and it's not just something that came up internally.

[jcesarmobile]

I created the issue and nobody has added the 👍 reaction to it, so I guess nobody was affected by it.

[NiklasMerz]

As this fix needs this PR to be released with cordova-ios apache/cordova-ios#1031 I think we could wait for that or are there reasons to release inappbrowser now as 5.0.0? The milestone looks good.

[nmanikiran]

Hi @NiklasMerz
i am facing issues with cookie sync between wkwebview & InappBrowser even after updating to v5.0.0
for more i logged an issue