-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-3360: Set custom inappbrowser user agent for ios #94
Conversation
Yeah I also need this. 👍 |
👍 |
There is a minor difference with pull request in cordova-ios. |
One side effect of this is that the main cordova webview will also have its userAgent changed (navigator.appVersion) once at least one instance of InAppBrowser has been created. It seems the userAgent setting will apply to all webviews. |
Yeah, on iOS the user agent change applies to all the webviews, maybe it should be restored after closing the inappbrowser |
This is basically the last thing I need before I am able to push my iOS app version. I would love to see the status of what's happening here, and also if anyone has any insight on how to implement this into a project :) (sorry for n00b question) |
👍 |
…os implementation - Does have the same issues as apache#94
Any chances to get this merged ? 😄 |
This has been merged already. A plugin release is pending: 98b63cc @cjpearson you can close this PR now. |
My bad ! Thank you for the information ! |
But where is the fix for iOS? |
@cjpearson can you rebase this? It can't be pulled in cleanly anymore. |
df2e82f
to
c84daf9
Compare
@shazron, just did a rebase. |
This closes apache#94 Signed-off-by: Shazron Abdullah <shazron@gmail.com>
…os implementation - Does have the same issues as apache#94
This uses the same OverrideUserAgent and AppendUserAgent properties as the pull requests for cordova-ios and cordova-android.