Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-3360: Set custom inappbrowser user agent for ios #94

Closed
wants to merge 1 commit into from

Conversation

cjpearson
Copy link
Contributor

This uses the same OverrideUserAgent and AppendUserAgent properties as the pull requests for cordova-ios and cordova-android.

@staugaard
Copy link

Yeah I also need this. 👍

@LennardWesterveld
Copy link

👍

@sinofool
Copy link

sinofool commented May 5, 2015

There is a minor difference with pull request in cordova-ios.
The original OverrideUserAgent will also ignore AppendUserAgent configuration.
If both configs provided, the behaviour will be different.

@samkelleher
Copy link

One side effect of this is that the main cordova webview will also have its userAgent changed (navigator.appVersion) once at least one instance of InAppBrowser has been created. It seems the userAgent setting will apply to all webviews.

@jcesarmobile
Copy link
Member

Yeah, on iOS the user agent change applies to all the webviews, maybe it should be restored after closing the inappbrowser

@willmero
Copy link

This is basically the last thing I need before I am able to push my iOS app version. I would love to see the status of what's happening here, and also if anyone has any insight on how to implement this into a project :) (sorry for n00b question)

@Justin-Credible
Copy link

👍

@Quelu
Copy link

Quelu commented Apr 18, 2016

Any chances to get this merged ? 😄

@shazron
Copy link
Member

shazron commented Apr 18, 2016

This has been merged already. A plugin release is pending: 98b63cc

@cjpearson you can close this PR now.

@Quelu
Copy link

Quelu commented Apr 18, 2016

My bad ! Thank you for the information !

@cjpearson cjpearson closed this Apr 20, 2016
@androdel
Copy link

But where is the fix for iOS?

@cjpearson cjpearson reopened this Apr 29, 2016
@shazron
Copy link
Member

shazron commented Jun 30, 2016

@cjpearson can you rebase this? It can't be pulled in cleanly anymore.

@cjpearson
Copy link
Contributor Author

@shazron, just did a rebase.

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Link Link Link

@asfgit asfgit closed this in 4ef6106 Jul 1, 2016
MLaudren pushed a commit to MLaudren/cordova-plugin-inappbrowser that referenced this pull request Oct 27, 2016
This closes apache#94

Signed-off-by: Shazron Abdullah <shazron@gmail.com>
grexican pushed a commit to grexican/cordova-plugin-themeablebrowser that referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet