Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Closes #290: InAppBrowser will not destroy WebView after being… #982

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dtarnawsky
Copy link

… closed (by invoking ref.close()) causing memory leaks

Platforms affected

Android

Motivation and Context

Fixes open issue 290

Description

When a web view is closed its resources are deallocated (Android).

Testing

Tested by ensuring memory was deallocated and closed web view no longer displayed when inspecting with chrome inspector.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

… closed (by invoking ref.close()) causing memory leaks
@NiklasMerz NiklasMerz added this to the 5.next milestone Nov 11, 2022
@ath0mas
Copy link

ath0mas commented Aug 16, 2023

Duplicate of #882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InAppBrowser will not destroy WebView after being closed (by invoking ref.close()) causing memory leaks
3 participants