Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-11086 (Android) Fixed a crash when setVolume() is called #109

Merged
merged 1 commit into from
Aug 24, 2016
Merged

CB-11086 (Android) Fixed a crash when setVolume() is called #109

merged 1 commit into from
Aug 24, 2016

Conversation

alsorokin
Copy link
Contributor

Platforms affected

Android

What does this PR do?

This is a fix for https://issues.apache.org/jira/browse/CB-11086
It fixes the crash by checking if player is null when trying to set player's volume.

What testing has been done on this change?

Tested on Android emulator 4.4, also checked that added test spec is green on iOS and Windows.

Checklist

  • ICLA has been signed and submitted to secretary@apache.org.
  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Link Link Link

@vladimir-kotikov
Copy link
Member

LGTM

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Link Link Link

@alsorokin alsorokin closed this Aug 24, 2016
@alsorokin alsorokin deleted the CB-11086 branch August 24, 2016 09:47
@asfgit asfgit merged commit 4d7aabb into apache:master Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants