Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-11380 (ios) Fixed an unexpected error callback when initializing M… #112

Merged
merged 1 commit into from Aug 26, 2016
Merged

CB-11380 (ios) Fixed an unexpected error callback when initializing M… #112

merged 1 commit into from Aug 26, 2016

Conversation

alsorokin
Copy link
Contributor

Platforms affected

iOS

What does this PR do?

Eliminates an unexpected error callback when initializing Media with the file that doesn't exist:
https://issues.apache.org/jira/browse/CB-11380

What testing has been done on this change?

Tested manually on iOS 8.1

Checklist

  • ICLA has been signed and submitted to secretary@apache.org.
  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@alsorokin
Copy link
Contributor Author

@shazron could you please help review this?

This fixes a regression caused by #85

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Link Link Link

@shazron
Copy link
Member

shazron commented Aug 25, 2016

LGTM 👍

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Link Link Link

@alsorokin alsorokin closed this Aug 26, 2016
@alsorokin alsorokin deleted the CB-11380 branch August 26, 2016 08:50
@asfgit asfgit merged commit 910d3c7 into apache:master Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants