fix(android): remove READ_PHONE_STATE permission #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpio
moved this from 🐣 New PR / Untriaged
to ⛔ Blocked: Tests failing
in Apache Cordova: Plugin Pull Requests
janpio
changed the title
janpio
moved this from ⛔ Blocked: Tests failing
to ⏳ Ready for Review
in Apache Cordova: Plugin Pull Requests
erisu
approved these changes
Apr 27, 2022
Apache Cordova: Plugin Pull Requests
automation
moved this from ⏳ Ready for Review
to ✅ Approved, waiting for Merge
Apr 27, 2022
breautek
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Android docs states:
Allows read only access to phone state, including the current cellular network information, the status of any ongoing calls, and a list of any PhoneAccounts registered on the device.
READ_PHONE_STATE was added/released in version 0.2.7 with no attached issue or jira ticket neither in the release notes or in the commit
Furthermore, even though the permission was declared, I don't see anywheres where it actually requests the permission. Not sure what was the intent of it being added but I agree it should be removed.
Apache Cordova: Plugin Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to 🏆 Merged, waiting for Release
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
The plugin uses the
OnAudioFocusChangeListenerto listen to audio focus changes such as the ones that happen on incoming calls. There is no need to request theandroid.permission.READ_PHONE_STATEbecause it is not needed.I think it's good to remove such permission because it has a dangerous protection level.
Description
Removed
<uses-permission android:name="android.permission.READ_PHONE_STATE" />frromplugin.xml