Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(browser): disable test cases w/ play() due to Autoplay Policy #318

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 6, 2021

Platforms affected

Browser (Test Specs)

Motivation and Context

Test failing due to Chrome's Autoplay Policy

Description

This PR disables test case 21, 22, and 27 because these calls play() method which is against Chrome's Autoplay Policy.

The Error:

Uncaught (in promise) DOMException: play() failed because the user didn't interact with the document first. https://goo.gl/xX8pDD

The Reason:

The Autoplay Policy launched in Chrome 66 for audio and video elements and is effectively blocking roughly half of unwanted media autoplays in Chrome. For the Web Audio API, the autoplay policy launched in Chrome 71. This affects web games, some WebRTC applications, and other web pages using audio features. More details can be found in the Web Audio API section below.

Testing

  • CI

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu merged commit 70a78a2 into apache:master Oct 6, 2021
@erisu erisu deleted the test/chrome-test-fix branch October 6, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants