Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep!: bump cordova-plugin-file@^7.0.0 #334

Merged
merged 4 commits into from
Apr 25, 2022
Merged

dep!: bump cordova-plugin-file@^7.0.0 #334

merged 4 commits into from
Apr 25, 2022

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Apr 13, 2022

Platforms affected

chore

Motivation and Context

File Plugin v7 has recently been released, but it can not be used together with current media plugin because it does not match the range ^6.0.0 set here.

Description

Change range to >=6.0.0.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@ath0mas
Copy link
Contributor Author

ath0mas commented Apr 13, 2022

But is this <dependency to cordova-plugin-file even necessary?
I haven't found any use of it in this project, nothing like require('cordova-plugin-file.Xxx');.
Shall we simply remove it instead of updating the range?

@erisu
Copy link
Member

erisu commented Apr 13, 2022

@ath0mas
Copy link
Contributor Author

ath0mas commented Apr 13, 2022

It is used: https://github.com/apache/cordova-plugin-media/blob/master/src/ios/CDVSound.m#L19

Ok fine, so I stay with my original changes for this PR.

plugin.xml Outdated Show resolved Hide resolved
plugin.xml Outdated Show resolved Hide resolved
@ath0mas ath0mas changed the title Change dependency to cordova-plugin-file >=6.0.0 Compatibility with cordova-plugin-file 7 Apr 21, 2022
@ath0mas ath0mas requested a review from erisu April 22, 2022 23:22
@erisu erisu changed the title Compatibility with cordova-plugin-file 7 dep!: bump cordova-plugin-file@7 Apr 25, 2022
@erisu erisu changed the title dep!: bump cordova-plugin-file@7 dep!: bump cordova-plugin-file@7.0.0 Apr 25, 2022
@erisu erisu changed the title dep!: bump cordova-plugin-file@7.0.0 dep!: bump cordova-plugin-file@^7.0.0 Apr 25, 2022
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased the PR and corrected the version information to match the next major target release.

Everything is good and will be merged in shortly.

@erisu erisu added this to the 6.0.0 milestone Apr 25, 2022
@erisu erisu merged commit 6419757 into apache:master Apr 25, 2022
@ath0mas ath0mas deleted the patch-1 branch April 25, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants