feat(android): drop WRITE_EXTERNAL_STORAGE permission #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
force-pushed
the
feat/drop-WRITE_EXTERNAL_STORAGE
branch
from
192f971
to
cda1198
Compare
breautek
reviewed
May 24, 2022
erisu
force-pushed
the
feat/drop-WRITE_EXTERNAL_STORAGE
branch
from
cda1198
to
784d439
Compare
breautek
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Drop the
WRITE_EXTERNAL_STORAGEpermission declaration since its protection level is dangerous.Closes #316
Description
Removed the
WRITE_EXTERNAL_STORAGEpermission declare fromplugin.xmlTesting
Checklist
(platform)if this change only applies to one platform (e.g.(android))