Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): load media files with custom scheme+hostname and leading directory paths #362

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 12, 2022

Platforms affected

ios

Motivation and Context

Able to load media file paths that are written in custom scheme+hostname format or with a leading slash to represent root directory of "www"

Description

Updated conditional checks

Testing

// const mediaFile = "https://www...wav";
// const mediaFile = cordova.file.applicationDirectory + '/www/media/test.wav';
// const mediaFile = 'app://localhost/media/test.wav';
const mediaFile = '/media/test.wav';

const myMedia = new Media(mediaFile, onSuccess, onError);
myMedia.play();

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu marked this pull request as ready for review October 18, 2022 11:42
@erisu erisu force-pushed the feat/support-custom-scheme-and-leading-root-directory-paths branch from 2eee3c6 to 52aaf41 Compare September 5, 2023 03:30
@erisu erisu merged commit 206f1b6 into apache:master Sep 6, 2023
9 of 10 checks passed
@erisu erisu deleted the feat/support-custom-scheme-and-leading-root-directory-paths branch September 6, 2023 12:40
kntrs pushed a commit to dejiren/cordova-plugin-media-m4a that referenced this pull request Sep 25, 2023
kntrs added a commit to dejiren/cordova-plugin-media-m4a that referenced this pull request Oct 10, 2023
schlingel pushed a commit to schlingel/cordova-plugin-media that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants