Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): increase audio encoding bitrate and sampling rate #383

Merged
merged 1 commit into from Aug 22, 2023

Conversation

erisu
Copy link
Member

@erisu erisu commented Aug 22, 2023

Platforms affected

Android

Motivation and Context

Improve audio recording quality

Closes #331

Note: This PR is setting the bitrate to 96 Kbps and not 128 Kbps. This plugin uses the AAC encoder, which generally provides better quality audio at a lower bitrate compared against MP3 encoder. While researching acceptable bitrate of AAC compared against MP3, some suggest using 96 Kbps for AAC while MP3 would be 128 Kbps. But this does not mean it is identical. In terms of quality, it will always result in source and equiptment.

Description

Increased following settings:

  • Audio BitRate -> 96000 (96 Kbps)
  • Audio Sampling Rate -> 44100 (44.1 kHz)

Testing

  • Tested recording audio on Google Pixel 6a (Android 13) device.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu merged commit 957249b into apache:master Aug 22, 2023
5 of 10 checks passed
@erisu erisu deleted the feat/android-bitrate-sampling-rate branch August 22, 2023 14:36
kntrs pushed a commit to dejiren/cordova-plugin-media-m4a that referenced this pull request Sep 25, 2023
schlingel pushed a commit to schlingel/cordova-plugin-media that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record in 128 kbps
2 participants