fix(android): avoid seeking on media without duration (CB-11314) #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also a problem with MP3 files where android (for whatever reason) cannot read the duration of the file. This could be some slight corruption to the file over time or it could be simply an encoding format that android doesn't like. This is pretty well documented with people having to work around the same issue in native audioplayers that use the same underlying frameworks. I went insane trying to figure out why iOS would seek within a local file but Android intermittently wouldn't. I'm definitely going to give this PR a test! |
|
There is a merge conflict now @schoetty. Could you maybe fix that please? Thanks. |
janpio
moved this from ⏳ Waiting for Review
to 💥 Blocked: Conflict
in Apache Cordova: Plugin Pull Requests
janpio
changed the title
janpio
moved this from 💥 Blocked: Conflict
to ⏳ Ready for Review
in Apache Cordova: Plugin Pull Requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android >= 6.0, live streams do not start playing. This is because the
onPreparedmethod ofAudioPlayerinvokesseekTo, what leads to an error because live streams have no duration and hence can not be seeked.