CB-13193: (ios) Fixed Lock iOS Landscape Orientation turn up-sidedown

[fortunes-technology]

Platforms affected

iOS

What does this PR do?

In iOS, the Landscape have opposite orientation.
Meaning if you do below when you are in landscape orientation, then you will notice the screen flips to opposite landscape orientation.
screen.orientation.lock(screen.orientation.type);

What testing has been done on this change?

Manual testing on iPhone has been done.

[fpirsch]

👍

[jfbloom22]

Thanks! Verified this fixes the issue for me on iOS 11.2.2 iPad mini 4.

[whodeee]

Any chance you can get the plugin updated, when getting it using cordova CLI, it is not showing this update.

[procom]

Hello,

+1 @whodeee

These fixes are not integrate in the release

[fortunes-technology]

The Merge conflict fixed.
This PR fixes, the landscape right and left issue.
Also if you want to lock orientation to landscape (do not care when it is right or left) and it's already in landscape mode (whether it is right or left), we shouldn't be changing orientation.
Right now, if we change orientation to landscape, it just change it to landscape left.
So this is fixed with this PR.

[ptorrent]

Hello,

I don't understand how works this plugin..

If I do screen.orientation.lock('portrait') , it changes nothing.
screen.orientation.lock('landscape') too..
I can always change the orientation of my screen.

If I close the application and go back inside , it's works!

Thanks for your reply

[SteveEdson]

Please can this be merged? I'm also experiencing this issue and need the fix. Thanks!

[davidofwatkins]

I can confirm this works for me as well (iPhone 5, iOS 10.3.3).

[fortunes-technology]

@macdonst @purplecabbage @stevengill
Can someone review this PR please?

[sbatezat]

Any chance to see this PR released in a tag?

[jfougere]

Any news of a 3.0.2 release ?

[ghost]

@maverickmishra do you have any insight into whether a 3.0.2 release of this plugin is planned? If not, do you know who would? Thank you.

[davidofwatkins]

+1, any news here about getting this into an official release @jcesarmobile?

[janpio]

3.0.2 has been released and contains this change.