Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate device only if needed #20

Closed
wants to merge 2 commits into from
Closed

Conversation

sbatezat
Copy link

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Update orientation only if needed.
Prevent switch from UIInterfaceOrientationLandscapeLeft to UIInterfaceOrientationLandscapeRight and from UIInterfaceOrientationPortraitUpsideDown to UIInterfaceOrientationPortrait
Using of [UIApplication sharedApplication].statusBarOrientation
@sbatezat sbatezat changed the title Do not rotate if orientation is OK Rotate device only if needed Jun 30, 2017
@jonathanloske
Copy link

Doesn't work for me if I want to lock the orientation to landscape but the device is in portrait. The UI should rotate into landscape in this case but it doesn't do so with these changes.

@jonathanloske
Copy link

jonathanloske commented Aug 18, 2017

Created bug report CB-13193 for this.

@jcesarmobile
Copy link
Member

Closing in favour of #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants