New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-13737 (iOS): fix Splash screen images for iPhone X #146
Conversation
I can't wait for this PR to be merged! |
@idoodler have you tried? does it work fine for you? |
@jcesarmobile Yes, I can confirm, it is working on my iPhone X (Real device) |
@jcesarmobile was thinking about creating a PR on my own, then saw your solution. We have nearly the same implementation, with the only difference that i split up iphone6Plus and iPhoneX conditions for more readability. However +1 for your solution! |
Yeah, I did it this way to avoid duplicating the landscape/portrait part, we could probably improve that part entirely. I will merge it later |
Whats up with the continuous integration test? It looks like the error has nothing to to with this fix. |
@idoodler yeah, the test failure has nothing to do with the PR, they fail for Android. But that wasn't stopping me from merging, I just didn't have time yesterday. |
Thank you!!! |
This fixed it for us as well, thanks! |
Platforms affected
iOS
What does this PR do?
Takes into account iPhone X sizes for splash screen
What testing has been done on this change?
Tested on iPhone X
Checklist