Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md by adding missing info #239

Merged
merged 7 commits into from Jan 12, 2020
Merged

Conversation

mosabab
Copy link
Contributor

@mosabab mosabab commented Nov 14, 2019

Platforms affected

iOS & Android

Description

  • Notify users to use new storyboard for ios.
  • Adding port & land xxxhdpi splash screen size for android.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek
Copy link
Contributor

breautek commented Nov 14, 2019

Because the two changes included in this PR is not really related I feel like these changes should be two different PRs (or at the very least, 2 different commits). One for the iOS note, another for xxxhdpi screen size.

@mosabab
Copy link
Contributor Author

mosabab commented Nov 14, 2019

You are true, but these are information need to update readme file to new info. I don’t think it is matter to use into 2 PR because it is update the documents to the new details.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@mosabab mosabab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update text as standard text

Copy link
Contributor Author

@mosabab mosabab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor Author

@mosabab mosabab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@mosabab
Copy link
Contributor Author

mosabab commented Nov 14, 2019

@breautek Could you please take a look now, thanks

README.md Outdated Show resolved Hide resolved
@mosabab
Copy link
Contributor Author

mosabab commented Nov 14, 2019

I update it as standard as you mentioned, please check

README.md Outdated Show resolved Hide resolved
@mosabab
Copy link
Contributor Author

mosabab commented Nov 14, 2019

The text is now as standard method, please review it.

Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change 😄

We lost our newline along the way,

README.md Outdated Show resolved Hide resolved
@mosabab
Copy link
Contributor Author

mosabab commented Nov 14, 2019

Thanks for info, updated ! , please review it.

@breautek
Copy link
Contributor

Thanks for your contribution, I think this is good enough merge!

@breautek breautek merged commit a7706fe into apache:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants