Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android overlay support to README #97

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

Menardi
Copy link
Contributor

@Menardi Menardi commented May 28, 2018

Platforms affected

N/A

What does this PR do?

Updates the README to:

  • Add Android as a supported platform for StatusBarOverlaysWebView - support for this was added in v2.2.3 but never added to the README
  • Remove references to iOS 7 where it is implied to be the latest version of iOS. It's not likely that anyone now cares about iOS 7!

What testing has been done on this change?

N/A

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@Menardi Menardi force-pushed the Menardi-patch-1 branch 2 times, most recently from 01c11cb to 340b873 Compare June 22, 2018 02:59
Also removed most references to iOS 7 which imply it is a very new version
@ManigandanRaamanathan
Copy link

Overlay is not working on android. Always gets a black status bar

@ManigandanRaamanathan
Copy link

Using StatusBar.overlaysWebView(true) makes the entire statusbar background invisible but the content of the page obstruct (goes/overlays through) the status bar since there is no status bar

@Menardi
Copy link
Contributor Author

Menardi commented Jun 27, 2018

@ManigandanRaamanathan If you want a semi-transparent status bar, you can do this, which is actually part of the docs improvement in this PR:

StatusBar.overlaysWebView(true);
StatusBar.backgroundColorByHexString('#33000000');

Otherwise, if you think there is an actual bug, you should file it at the Cordova JIRA.

@janpio janpio merged commit 053a902 into apache:master Jul 18, 2018
@ManigandanRaamanathan
Copy link

Will it work after the latest commit?

The below fix did not work:-
overlaysWebView(true);
StatusBar.backgroundColorByHexString('#33000000');

@janpio
Copy link
Member

janpio commented Jul 18, 2018

@ManigandanRaamanathan http://issues.cordova.io is the correct place to talk about this, not a PR. Thank you.

@Menardi Menardi deleted the Menardi-patch-1 branch July 19, 2018 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants