Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): make default set black text on iOS 13 too #169

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Nov 1, 2019

Platforms affected

ios

Motivation and Context

Closes #148

Description

on iOS 13, default depends on the device mode.
This PR forces default to always black.

Testing

Tested on iOS 13 device and iOS 11 device on Xcode 10 and 11

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@danielehrhardt
Copy link

Nice!! Should be merged

@rojasss11
Copy link

Thank you @jcesarmobile . It solved my problem.
Pls, merge the request.

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I haven't done any tests.

@tymarats
Copy link

Any chance this could be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 13 dark mode default text colour is white
5 participants