Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)

[exxbrain]

Platforms affected

All platforms, especially iOS.

Motivation and Context

Fixes #164. Fixes #162.
It has been already fixed but not completely correctly. iOS statusbar has different behaviour for Default and Dark styles.

Description

Added styleDarkContent similar to styleLightContent

Testing

Tested on iPhone SE with iOS 13, Android emulator SDK 29.

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[jcesarmobile]

I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.

[exxbrain]

I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.

Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.

Also the default statusbar behaviour has became unavailable for iOS13 in master branch. This pull request fixes it.

I think it Fixes #162 correctly as well.

[NiklasMerz]

To me this makes more sense. Otherwise I have to implement app logic to set the right statusbar color and what makes this harder that there is no explicit dark style.

[svzi]

Any update on this topic? When to expect a new official release with this PR merged? 🤔

[omargon]

Anyway we can help push this out? Really needed as it is probably the only pending use case when dealing with light and dark mode settings right now.

[aml25]

I'm using @exxbrain PR master and it's working great on iOS.

The behavior is opposite on Android when setting style using config.xml - so <preference name="StatusBarStyle" value="darkcontent" /> yields white text in the status bar on Android, but black on iOS.

If I set the style using JS StatusBar.styleDarkContent(); then it works as expected on Android.

[SunboX]

What's the current state on this issue? It's really important on iOS now.

[timbru31]

I'd like to get this PR merged, requesting some more eyes. I feel this is the cleaner approach, too.
I will take care of resolving the conflicts if you are fine, too.

[jcesarmobile]

I think we should get a release as is and then do another release with this changes and also removing all the styles that don't work since iOS 7 (that has been deprecated for over a year in the plugin but not officially since it wasn't released)

Not to mention that the PR has conflicts and the documentation is misleading since this is iOS 13+ only and that is not mentioned on the doc changes

[nosTa1337]

Any updates here? It pretty annoying that the statusbar text is white on a bright background in iOS :)

[Maks113]

I also have a problem with this. Can anyone complete the merge?

[tobeagram]

I've also been having this issue, would love this to be merged asap! In the meantime @exxbrain's PR master works great but is a bit of out date, so I've merged it with the most up-to-date version of the current master.

I've made my repo public here for anyone who needs it to save some time until this PR is merged or an alternative solution is made available.

[simpian]

can this be merged to enable black text on light theme on dark mode?

[nvahalik]

Another 👍🏻 for this patch. We have come across this as well...