Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13045: Removed android implementation and Updated README #60

Merged
merged 3 commits into from Dec 12, 2017
Merged

CB-13045: Removed android implementation and Updated README #60

merged 3 commits into from Dec 12, 2017

Conversation

maverickmishra
Copy link
Member

The Android webview ( API level 19 and up ) natively supports the W3C spec and hence the android specific implementation can be dropped.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@janpio
Copy link
Member

janpio commented Dec 6, 2017

Note:
README still lists Android as supported platform for navigator.vibrate, navigator.notification.vibrate and navigator.notification.vibrateWithPattern.

Question:
Does that mean that users of the plugin have to build an if-block to differentiate between iOS and Android to call the W3C spec code for Android?

@maverickmishra
Copy link
Member Author

navigator.notification.vibrate and navigator.notification.vibrateWithPattern are already deprecated for the plugin. To answer your question, usage of navigator.vibrate will automatically use the W3C spec for Android and the iOS-specific code from the plugin for iOS.

@janpio
Copy link
Member

janpio commented Dec 6, 2017

navigator.notification.vibrate and navigator.notification.vibrateWithPattern are already deprecated for the plugin.

Ah ok, meaning that this change only drops support for cancelVibration where no standard support is available, thus only there the README is changed. Correct?

To answer your question, usage of navigator.vibrate will automatically use the W3C spec for Android and the iOS-specific code from the plugin for iOS.

Thanks for the clarification. Pays off if the plugins use the future standard APIs ;)

@macdonst
Copy link
Member

macdonst commented Dec 8, 2017

@maverickmishra considering this is a breaking API change and we'll be bumping the version to 3.0.0 we might as well take out vibrateWithPattern & cancelVibration.

@maverickmishra
Copy link
Member Author

Good idea! I'll make the necessary changes now

@maverickmishra maverickmishra merged commit 1420fc2 into apache:master Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants