Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): update types #75

Merged
merged 1 commit into from
Feb 13, 2019
Merged

fix(typescript): update types #75

merged 1 commit into from
Feb 13, 2019

Conversation

timbru31
Copy link
Member

  • deletes removed features
  • adds version number
  • format code

This is part of apache/cordova#39

Platforms affected

n/a - development with TypeScript

What does this PR do?

updates typings as discussed in apache/cordova#39

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

* deletes removed features
* adds version number
* format code

This is part of apache/cordova#39
@timbru31
Copy link
Member Author

I'm not able to request a specific reviewer, but pinging @janpio should work, too ;)

@janpio janpio merged commit 29a7fc4 into apache:master Feb 13, 2019
@janpio
Copy link
Member

janpio commented Feb 13, 2019

Yep, that works :)

@timbru31 timbru31 deleted the patch-1 branch February 13, 2019 20:57
@timbru31 timbru31 mentioned this pull request Feb 18, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants