This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
(ios) Bug fix in recent change in iOSExec.nativeCallback #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, callbackFromNative will actually get called async
jcesarmobile
suggested changes
Feb 18, 2019
alexhisen
changed the title
jcesarmobile
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Now, callbackFromNative will actually get called async. Before it was not.
See #49
Description
Use resolve.then() exactly same as in https://github.com/ionic-team/cordova-plugin-ionic-webview/blob/master/src/www/ios/ios-wkwebview-exec.js
Testing
Works in an actual app
Checklist
(platform)if this change only applies to one platform (e.g.(android))