This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
CB-11074 - Ensure settings from config.xml are taken into consideration #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2016
Note that there is a skipped unit test "testConfigurationWithMediaPlaybackAllowsAirPlay", which deals with an Apple bug in setting the WKWebViewConfiguration.allowsAirPlayForMediaPlayback value.
|
Without having tested this, it seems reasonable to me |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take note of the disabled
testConfigurationWithMediaPlaybackAllowsAirPlayunit test which demonstrates that the allowsAirPlayForMediaPlayback is not sticky (apparent Apple bug).Also,
mediaPlaybackRequiresUserActionconfiguration default differs on iOS 10 versus earlier versions (on iOS 10 it defaults to NO, when it was YES, previously). Probably due to: https://webkit.org/blog/6784/new-video-policies-for-ios/This preserves
updateWithInfowhich is needed to update other settings, which was deleted in the other two pull requests.