Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(ios): fix keyboard displacement bug in iOS 12 WKWebView #75

Closed
wants to merge 1 commit into from

Conversation

mwchambers
Copy link

@mwchambers mwchambers commented Jan 21, 2019

@tpneumat
Copy link

tpneumat commented Feb 15, 2019

any hope to see this included so I don't have to hack the plugin too? Moving to ionic is not a possibility without breaking local store so we need this fix for building in xcode 10. thx

@Goregut
Copy link

Goregut commented Feb 18, 2019

Curious about this too. Just start experiencing the keyboard issue as well.

@shahdeep1989
Copy link

Why It's not fixed yet? Can any one provide me solution for this issue?

@janpio janpio added this to 🐣 New PR / Untriaged in Apache Cordova: Plugin Pull Requests Jul 2, 2019
@janpio janpio moved this from 🐣 New PR / Untriaged to ⛔ Blocked: Tests failing in Apache Cordova: Plugin Pull Requests Jul 2, 2019
@janpio janpio changed the title Attempt to fix https://github.com/apache/cordova-plugin-wkwebview-eng… Attempt to fix #71 Jul 4, 2019
@janpio janpio changed the title Attempt to fix #71 fix(ios): fix keyboard displacement bug in iOS 12 WKWebView Jul 4, 2019
@janpio janpio added the bug label Jul 4, 2019
@janpio janpio closed this Jul 4, 2019
Apache Cordova: Plugin Pull Requests automation moved this from ⛔ Blocked: Tests failing to ☠️ Closed/Abandoned Jul 4, 2019
@janpio
Copy link
Member

janpio commented Jul 4, 2019

CI, please rerun tests.

@janpio janpio reopened this Jul 4, 2019
Apache Cordova: Plugin Pull Requests automation moved this from ☠️ Closed/Abandoned to 🐣 New PR / Untriaged Jul 4, 2019
@janpio
Copy link
Member

janpio commented Jul 4, 2019

And once more.

@janpio janpio closed this Jul 4, 2019
Apache Cordova: Plugin Pull Requests automation moved this from 🐣 New PR / Untriaged to ☠️ Closed/Abandoned Jul 4, 2019
@janpio janpio reopened this Jul 4, 2019
Apache Cordova: Plugin Pull Requests automation moved this from ☠️ Closed/Abandoned to 🐣 New PR / Untriaged Jul 4, 2019
@janpio janpio moved this from 🐣 New PR / Untriaged to ⏳ Ready for Review in Apache Cordova: Plugin Pull Requests Jul 4, 2019
@ChildishForces
Copy link

Can we look forward to this soon, given that all tests are passing?

@janpio
Copy link
Member

janpio commented Jul 9, 2019

Not from me, I don't review and approve (and merge) PRs that I don't fully understand (as is the case for all iOS code). Some other contributor will have to do that, I just made sure the tests were run successfully.

(You can of course just use https://github.com/mwchambers/cordova-plugin-wkwebview-engine from github directly until then.)

@joacim-boive
Copy link

joacim-boive commented Jul 17, 2019

I don’t think this is a valid fix.

If the page is scrolled, like when the entire form doesn’t fit in the view, the page will scroll to the top each time you interact with an input-element. This will quickly become extremely tiresome… ;)

This means: Click a dropdown, select a value, [ ScrolledToTop ], scrolling down, select another field, close the keyboard, [ ScrolledToTop ], rinse-and-repeat.

@mwchambers
Copy link
Author

mwchambers commented Jul 17, 2019

I don’t think this is a valid fix.

If the page is scrolled, like when the entire form doesn’t fit in the view, the page will scroll to the top each time you interact with an input-element. This will quickly become extremely tiresome… ;)

This means: Click a dropdown, select a value, [ ScrolledToTop ], scrolling down, select another field, close the keyboard, [ ScrolledToTop ], rinse-and-repeat.

I had not noticed this, however you are absolutely correct!

I've just tested it and it does behave how you've described. I guess https://github.com/ionic-team/cordova-plugin-ionic-webview/ must have the same issue.

Unfortunately I don't have the experience required to help with this any further.

Apache Cordova: Plugin Pull Requests automation moved this from ⏳ Ready for Review to 🙅 Reviewed, but not approved Jul 17, 2019
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge: #75 (comment)

@dpogue
Copy link
Member

dpogue commented Apr 21, 2020

This is resolved in iOS 13.4. For earlier versions of iOS, using the cordova-plugin-wkkeyboardfix is probably the best solution. We will not be making any changes to Cordova to address this bug.

@dpogue dpogue closed this Apr 21, 2020
Apache Cordova: Plugin Pull Requests automation moved this from 🙅 Reviewed, but not approved to ☠️ Closed/Abandoned Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging this pull request may close these issues.

When closing keyboard, content doesn't scroll back leaving ehite space in place of keyboard
8 participants