Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(npm): update package & add ignore list #27

Merged
merged 1 commit into from Apr 1, 2020
Merged

chore(npm): update package & add ignore list #27

merged 1 commit into from Apr 1, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 1, 2020

Motivation, Context, & Description

  • Cleanup npm package properties
  • Add npm ignore list

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 4.0.0 milestone Apr 1, 2020
@erisu erisu requested a review from timbru31 April 1, 2020 07:27
timbru31
timbru31 reviewed Apr 1, 2020
View reviewed changes
.npmignore Outdated Show resolved Hide resolved
timbru31
timbru31 requested changes Apr 1, 2020
View reviewed changes
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #29 adds a new "coverage" folder, this needs to go in the npmignore, too, shouldn't it?

@erisu erisu force-pushed the chore/npm-package-cleanup branch from 5e39f28 to 7298654 Compare April 1, 2020 07:52
@erisu
Copy link
Member Author

erisu commented Apr 1, 2020 •
edited

No, the coverage dir does not exist in master or in this PR. The coverage dependency is added I the GitHub Actions PR. When this is merged and Actions PR is rebased, the coverage dir will be added in that PR. This PR should not add what does not exist.

@erisu erisu requested a review from timbru31 April 1, 2020 07:52
@erisu erisu mentioned this pull request Apr 1, 2020
Merged
2 tasks
@erisu erisu merged commit 9987b6f into apache:master Apr 1, 2020
@erisu erisu deleted the chore/npm-package-cleanup branch April 1, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbru31 timbru31 timbru31 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erisu @timbru31