This repository has been archived by the owner on Jul 25, 2018. It is now read-only.
CB-10358: Add deprecation notice #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menardi
reviewed
Jul 5, 2018
README.md
Outdated
|
|
||
| weinre was built in an age when there were no remote debuggers available for mobile devices. Since then, some platforms are starting to provide remote debugger capabilities, as part of their platform tool set. | ||
|
|
||
| 1. Android: [Get Started with Remote Debugging Android Devicese](https://developers.google.com/web/tools/chrome-devtools/remote-debugging/) |
There was a problem hiding this comment.
Minor typo here, Devicese should be Devices
brodybits
reviewed
Jul 5, 2018
README.md
Outdated
| 1. iOS: [Safari Developer Tools overview](https://support.apple.com/guide/safari-developer/safari-developer-tools-overview-dev073038698/mac) | ||
| 1. Windows: [Debug Store apps in Visual Studio](https://msdn.microsoft.com/library/hh441472.aspx) | ||
|
|
||
| <mark>Important note</mark>, some of weinre dependencies have security issues, use on your own risk. |
There was a problem hiding this comment.
<mark> doesn't seem to do much if I click the View button
I would mark "Important note" in BOLD CAPS
There was a problem hiding this comment.
In VS Code it highlight it in yellow, but yeah, it doesn't do anything here, so I'll remove it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
Add deprecation notice to the README
What testing has been done on this change?
Checklist