This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
CB-11176 Fix windows-splashscreen compatibility with older plugin ver… #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var pluginsVersions = require("cordova/plugin_list").metadata; | ||
| var splashscreenVersion = pluginsVersions['cordova-plugin-splashscreen']; | ||
| var MIN_SPLASHSCREEN_SUPPORTED_VER = 4; | ||
| if (splashscreenVersion && parseInt(splashscreenVersion[0], 10) < MIN_SPLASHSCREEN_SUPPORTED_VER) { |
There was a problem hiding this comment.
Is it supposed to not work for 4.x versions as well?
There was a problem hiding this comment.
This regards to the plugin version and not to the platform' one, i.e. it should work starting with cordova-plugin-splashscreen@4 (as it will just redirect API calls to the platform).
|
Minor comments. Otherwise LGTM. |
Current coverage is 73.42%@@ master #172 diff @@
==========================================
Files 14 14
Lines 1862 1862
Methods 342 342
Messages 0 0
Branches 379 379
==========================================
Hits 1367 1367
Misses 495 495
Partials 0 0
|
| if (service === 'SplashScreen') { | ||
| var pluginsVersions = require("cordova/plugin_list").metadata; | ||
| var splashscreenVersion = pluginsVersions['cordova-plugin-splashscreen']; | ||
| var MIN_SPLASHSCREEN_SUPPORTED_VER = 4; |
There was a problem hiding this comment.
From this line, should I understand that the next 4.x.x release here https://github.com/apache/cordova-plugin-splashscreen/releases will be fully compatible with windows ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sions
Jira issue with details