Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

CB-11836 Allow setting of 'ForegroundText' property via config.xml #195

Closed
wants to merge 7 commits into from
Closed

CB-11836 Allow setting of 'ForegroundText' property via config.xml #195

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d177c76
Allow setting of 'ForegroundText' property via config.xml
Sep 8, 2016
6a61635
Fixed quote style
Sep 8, 2016
91e6b9e
ForegroundText property is not used for Windows 10 anymore
Sep 21, 2016
a879ad8
Removed ForegroundText argument check
Sep 21, 2016
d90eaf4
Added basic tests for setting and getting 'ForegroundText'
Sep 21, 2016
74d1713
Change 'ForegroundText' back to default if it is missing
Sep 21, 2016
55dadc8
Added test for 'ForegroundText' default value
Sep 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions template/cordova/lib/AppxManifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,21 @@ AppxManifest.prototype.getVisualElements = function () {
return this.setBackgroundColor(color);
} catch (e) { return this; }
},
getForegroundText: function () {
return visualElements.attrib.ForegroundText;
},
setForegroundText: function (color) {
if (color) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of if (color) { visualElements.attrib.ForegroundText = color; } would it be better to use visualElements.attrib.ForegroundText = color || 'light' so that ForegroundText would be reset as default light if we set dark via preference for example and then remove the preference from config.xml entirely?

// Foreground color can either be dark or light, light is the default
if (color !== 'dark') {
color = 'light';
}

visualElements.attrib.ForegroundText = color;
}

return this;
},
getSplashBackgroundColor: function () {
var splashNode = visualElements.find('./' + self.prefix + 'SplashScreen');
return splashNode && splashNode.attrib.BackgroundColor;
Expand Down
1 change: 1 addition & 0 deletions template/cordova/lib/prepare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ function updateManifestFile (config, manifestPath) {
// Apply background color, splashscreen background color, etc.
manifest.getVisualElements()
.trySetBackgroundColor(config.getPreference('BackgroundColor'))
.setForegroundText(config.getPreference('ForegroundText'))
.setSplashBackgroundColor(config.getPreference('SplashScreenBackgroundColor'))
.setToastCapable(config.getPreference('WindowsToastCapable'))
.setOrientation(config.getPreference('Orientation'));
Expand Down