[WIP] Win10 only #264
[WIP] Win10 only #264
Conversation
janpio
force-pushed
the
janpio-win10only
branch
from
6236b85
to
34c29b3
Compare
|
I feel a bit ambivalent about this change right now. I continue to support legacy sqlite plugin version for pre-win10, not sure that the need has completely gone away yet. |
|
Windows 8 / Windows 8.1 is gone - about 7% marketshare source. So at least for cordova development activities this shouldn't be a priority. If someone still relies on Windows 8/8.1 without a realistic upgrade path to 10.0 within the next year: please speak up now. |
|
If someone still uses Windows 8/8.1 they can just continue using the current release that still supports it. Getting rid of this code makes the platform much more manageable and maintainable. So much cruft will be gone. |
|
@janpio should we keep this PR open? |
|
Yes, unless you want to throw the work that went into creating this away, this would definitely make sense. |
janpio
added this to 👷 Blocked: Work in Progress
in Apache Cordova: Platform Pull Requests
erisu
moved this from In Progress
to Planning/Ideas
in Apache Cordova: Next Release Planning and Tracking
|
What is the status of this proposal? |
|
| var isWp10 = navigator.appVersion.indexOf("Windows Phone 10") !== -1; | ||
| var isPhoneDevice = isWp81 || isWp10; | ||
| var isPhoneDevice = isWp10; |
There was a problem hiding this comment.
I would vote to drop isWp* and isPhone*, we just check if we are dealing with UWP, appx-web, etc.
There was a problem hiding this comment.
Fell free to do that in a PR, but don't take this as the base as it really was just a PoC to see what happens when I delete some code.
|
@janpio |
|
windows is now deprecated, thanks for your contribution |
Platforms affected
What does this PR do?
Removes all logic for non-Win10.
What testing has been done on this change?
Checklist