Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Support latest Visual Studio 2017 (15.9.x) #329

Merged
merged 1 commit into from
May 4, 2019
Merged

Conversation

janpio
Copy link
Member

@janpio janpio commented Apr 26, 2019

Latest Visual Studio 2017 comes with MSBuild 15.9:

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin
λ msbuild -version -nologo
15.9.21.664

As we have a strangely hardcoded list of support MSBuild versions, this needs to be added to work.

@janpio janpio requested review from erisu and raphinesse May 3, 2019 14:58
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@janpio janpio merged commit 95401b3 into master May 4, 2019
@janpio janpio deleted the janpio-vs17_15.9 branch May 4, 2019 16:26
@janpio
Copy link
Member Author

janpio commented May 4, 2019

Argh, failed after merge and turns out should have failed here as well - the AppVeyor build was red. Shit.

@janpio janpio added this to the 7.0.1 milestone May 7, 2019
brodybits pushed a commit to brodybits/cordova-windows that referenced this pull request Dec 23, 2019
@brodybits brodybits mentioned this pull request Dec 23, 2019
3 tasks
brodybits pushed a commit to brodybits/cordova-windows that referenced this pull request Dec 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants