Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to winjs dependency #331

Merged
merged 1 commit into from Apr 26, 2019
Merged

Fix path to winjs dependency #331

merged 1 commit into from Apr 26, 2019

Conversation

@raphinesse
Copy link
Contributor

raphinesse commented Apr 26, 2019

Motivation and Context

Fixes #326

Description

Properly resolve the path to our dependency instead of guessing it.

Testing

Manual:

$ cordova create cordovaWindows7Test
Creating a new cordova project.
$ cd cordovaWindows7Test
$ cordova platform add ~/code/cordova-windows
Warning: using prerelease platform windows@7.1.0-dev.
Use 'cordova platform add windows@latest' to add the latest published version instead.
Adding windows project...
Creating Cordova Windows Project:
	Path: platforms/windows
	Namespace: io.cordova.hellocordova
	Name: HelloCordova
Windows project created with cordova-windows@7.1.0-dev
Plugin 'cordova-plugin-whitelist' found in config.xml... Migrating it to package.json
Discovered saved plugin "cordova-plugin-whitelist". Adding it to the project
Installing "cordova-plugin-whitelist" for windows
Adding cordova-plugin-whitelist to package.json

Unfortunately, a regression test is not easily to be had. The Problem is that, in our E2E tests, create copies the node_modules folder to where it expects it later when copying the winjs file. In a multi-platform project setup via CLI, the layout is different and node_modules is not copied in the first place.

Fixes #326
@raphinesse raphinesse added the bug label Apr 26, 2019
@raphinesse raphinesse requested review from janpio and erisu Apr 26, 2019
@erisu
erisu approved these changes Apr 26, 2019
Copy link
Member

erisu left a comment

👍

@janpio janpio merged commit f2d5d08 into apache:master Apr 26, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raphinesse raphinesse deleted the raphinesse:fix-326 branch Apr 26, 2019
@janpio janpio added this to the 7.0.1 milestone May 7, 2019
@janpio janpio mentioned this pull request Jun 26, 2019
3 of 3 tasks complete
@regnete

This comment has been minimized.

Copy link

regnete commented Jul 4, 2019

brodybits added a commit that referenced this pull request Dec 22, 2019
brodybits added a commit to brodybits/cordova-windows that referenced this pull request Dec 23, 2019
@brodybits brodybits mentioned this pull request Dec 23, 2019
3 of 3 tasks complete
brodybits added a commit to brodybits/cordova-windows that referenced this pull request Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.