Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Fix path to winjs dependency #331

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Fix path to winjs dependency #331

merged 1 commit into from
Apr 26, 2019

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Apr 26, 2019

Motivation and Context

Fixes #326

Description

Properly resolve the path to our dependency instead of guessing it.

Testing

Manual:

$ cordova create cordovaWindows7Test
Creating a new cordova project.
$ cd cordovaWindows7Test
$ cordova platform add ~/code/cordova-windows
Warning: using prerelease platform windows@7.1.0-dev.
Use 'cordova platform add windows@latest' to add the latest published version instead.
Adding windows project...
Creating Cordova Windows Project:
	Path: platforms/windows
	Namespace: io.cordova.hellocordova
	Name: HelloCordova
Windows project created with cordova-windows@7.1.0-dev
Plugin 'cordova-plugin-whitelist' found in config.xml... Migrating it to package.json
Discovered saved plugin "cordova-plugin-whitelist". Adding it to the project
Installing "cordova-plugin-whitelist" for windows
Adding cordova-plugin-whitelist to package.json

Unfortunately, a regression test is not easily to be had. The Problem is that, in our E2E tests, create copies the node_modules folder to where it expects it later when copying the winjs file. In a multi-platform project setup via CLI, the layout is different and node_modules is not copied in the first place.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@janpio janpio merged commit f2d5d08 into apache:master Apr 26, 2019
@raphinesse raphinesse deleted the fix-326 branch April 26, 2019 12:36
@janpio janpio added this to the 7.0.1 milestone May 7, 2019
@regnete
Copy link

regnete commented Jul 4, 2019

#341 (comment)

brodybits pushed a commit that referenced this pull request Dec 22, 2019
brodybits pushed a commit to brodybits/cordova-windows that referenced this pull request Dec 23, 2019
@brodybits brodybits mentioned this pull request Dec 23, 2019
3 tasks
brodybits pushed a commit to brodybits/cordova-windows that referenced this pull request Dec 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base.js not copied when adding windows platform @7.0.0
4 participants