Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Silence test output #367

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Silence test output #367

merged 2 commits into from
Oct 30, 2019

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

Fixes #352

Description

  • Emit events instead of calling console.log
  • Avoid subscribing global events to logger in unit-tests

@raphinesse raphinesse added this to the 7.0.1 milestone Oct 30, 2019
@raphinesse raphinesse merged commit 442a550 into apache:master Oct 30, 2019
@raphinesse raphinesse deleted the silence-test-output branch October 30, 2019 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erisu erisu erisu approved these changes

@janpio janpio Awaiting requested review from janpio

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
7.0.1
Development

Successfully merging this pull request may close these issues.

Tests: test-unit has loads of unrelated warning output
2 participants
@raphinesse @erisu